D28909: smb: port to Result system to force serialization of error/finish condition

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kio_smb.cpp:162
> +{
> +#warning this was finishing before but in sftp and fish we do not finish so I guess not finishing is the way to go
> +    maybeError(d->special(data));

The KIO::SimpleJob needs to finish....

kio_file's special() -- which is where it all started -- does emit finish().

I'm pretty sure they should all do.

> kio_smb.h:96
> + */
> +struct Result
>  {

The class is simple enough, but I'm wondering if at some point we might want to provide it in KIO [as is, not with a d pointer].

> kio_smb.h:269
> +     * Used in open(), read(), write(), and close()
> +     * FIXME Placing these in the private section above causes m_openUrl = kurl
> +     * to fail in SMBSlave::open. Need to find out why this is.

parse error?

> kio_smb.h:276
> +    /* Enables a workaround for some broken libsmbclient versions */
> +    const bool m_enableEEXISTWorkaround = false;
> +};

the default value here is confusing and useless, since this member actually gets initialized by the constructor.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28909

To: sitter, dfaure
Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200418/34e3311c/attachment.htm>