D28801: Dolphin Service Menu installer cleanup

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
elvisangelaccio added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> servicemenuinstaller.cpp:278
>          if (!deinstallPath.isEmpty()) {
> -            bool ok = runInstallerScript(deinstallPath, false, QStringList{}, errorText);
> +            bool ok = runInstallerScript(deinstallPath, false, {}, errorText);
>              if (!ok) {

While at it, make it `const`.

REPOSITORY
  R318 Dolphin

BRANCH
  servicemenuinstaller_cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28801

To: alex, #dolphin, ngraham, nicolasfella, elvisangelaccio
Cc: elvisangelaccio, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200413/5c49c131/attachment.htm>