D28801: Dolphin Service Menu installer cleanup

Alexander Lohnau noreply at phabricator.kde.org
Mon Apr 13 18:35:56 BST 2020


alex created this revision.
alex added reviewers: Dolphin, ngraham, nicolasfella.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
alex requested review of this revision.

REVISION SUMMARY
  This patch contains some smaller formatting/coding style changes
  to avoid unrelated changes in other patches.
  
  - Use {} instead of QStringList{} consistently
  - Use parehthesese in `UncompressCommand({})` consistently
  - Use `QStringList name = {}` instead of `auto name = QStringList{}`
  - Add one qAsConst, remove qAsConst if value is already const

TEST PLAN
  Compile, install and run tests

REPOSITORY
  R318 Dolphin

BRANCH
  servicemenuinstaller_cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28801

AFFECTED FILES
  src/settings/services/servicemenuinstaller/servicemenuinstaller.cpp

To: alex, #dolphin, ngraham, nicolasfella
Cc: kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200413/75e87f5d/attachment.htm>


More information about the kfm-devel mailing list