D28486: File Size View: Port away from KDElibs4Support

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Nice work!

INLINE COMMENTS

> fsview.cpp:530
>  
>                  if (1) {
> +                    qCDebug(FSVIEWLOG) << "Phase 2: CSize " << _chunkSize1;

You could remove all the if(1), qCDebug is off by default and easy to turn on.

For the if(0), well, maybe a different verbose category... Anyway, not for this patch.

> fsview_part.cpp:151
>  
> -    slotSettingsChanged(KGlobalSettings::SETTINGS_MOUSE);
> -    connect(KGlobalSettings::self(), SIGNAL(settingsChanged(int)),
> -            SLOT(slotSettingsChanged(int)));
> +    // Both of these click signals are connected.  Whether a single or
> +    // double click activates an item is checked against the current

I thought there was an activated() signal to encapsulate this logic?

REPOSITORY
  R226 Konqueror

REVISION DETAIL
  https://phabricator.kde.org/D28486

To: marten, #plasma, #konqueror, dfaure
Cc: cfeck
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200404/3df1c1b4/attachment.htm>