D28227: Use same logic for "no extension" case with Duplicate feature

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> dolphinview.cpp:740
>              const QString originalExtension = originalFileName.right(extension.size());
> -            duplicateURL.setPath(i18nc("<file path><filename> copy.<extension>", "%1%2 copy%3", directoryPath, originalFilenameWithoutExtension, originalExtension));
> +            duplicateURL.setPath(originalDirectoryPath + i18nc("<filename> copy.<extension>", "%1 copy%2", originalFilenameWithoutExtension, originalExtension));
>          }

this is a case in which I think you even want more puzzle. getting this translated to %2%1copy makes no sense, the only thing you want translated here is "%1 copy" and then append the extenstion to that, the extension always has to be at the end right? That's something the filesystem mandates, not the translation

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D28227

To: ngraham, #dolphin, elvisangelaccio, arojas, meven, pino, #localization
Cc: aacid, kfm-devel, nikolaik, pberestov, iasensio, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200402/96343d4a/attachment.htm>