D28227: Use same logic for "no extension" case with Duplicate feature

[Nathaniel Graham]

ngraham added a reviewer: Localization.
ngraham added a comment.


  In D28227#640235 <https://phabricator.kde.org/D28227#640235>, @pino wrote:
  
  > Sorry, I missed that, also because slightly busier lately.
  
  
  No worries!
  
  > random tagging in phab
  
  That's how development using Phabricator works. Tagging #localization <https://phabricator.kde.org/tag/localization/> for opinions on whether it's appropriate to do something like this:
  
    duplicateURL.setPath(originalDirectoryPath + i18nc("<filename> copy", "%1 copy", originalFileName));
  
  Ordinarily I'd say this is a string puzzle, but `originalDirectoryPath` never needs to be localized, so is it okay?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D28227

To: ngraham, #dolphin, elvisangelaccio, arojas, meven, pino, #localization
Cc: kfm-devel, nikolaik, pberestov, iasensio, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200402/e49f2054/attachment.htm>