D19311: Add navigation history to forward/back buttons

[David Hallas]

hallas added a comment.


  In D19311#539582 <https://phabricator.kde.org/D19311#539582>, @elvisangelaccio wrote:
  
  > @hallas I noticed the following warning on dolphin start:
  >
  >   KXMLGUIFactoryPrivate::saveDefaultActionProperties(): Shortcut for action  "go_forward" "&Forward" set with QAction::setShortcut()! Use KActionCollection::setDefaultShortcut(s) instead.
  >   
  >
  > Could you have a look? Maybe it's because we call `actionCollection()->setDefaultShortcuts(m_backAction, backShortcuts);` and we don't do the same for `m_forwardAction` ?
  
  
  Yes I will take a look - thanks for the heads up :)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19311

To: hallas, #dolphin, ngraham, elvisangelaccio, #vdg
Cc: felixernst, nerdopolist, mart, richardl, ognarb, david.fontanals, abetts, kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190930/f841ef6b/attachment.htm>