D23557: Update dolphin tests following place changes D7446

Elvis Angelaccio noreply at phabricator.kde.org
Sun Sep 15 09:33:16 BST 2019


elvisangelaccio added inline comments.

INLINE COMMENTS

> CMakeLists.txt:74
>  # PlacesItemModelTest
> -if (KIO_VERSION VERSION_GREATER_EQUAL "5.60.0")
> +if (KF5_VERSION VERSION_GREATER_EQUAL 5.63.0)
>      ecm_add_test(placesitemmodeltest.cpp

I committed this fix separately on your behalf on the stable branch, please rebase this patch.

Which brings the question: should we push this patch to 19.08? Probably yes.

REPOSITORY
  R318 Dolphin

BRANCH
  arcpatch-D23557_1

REVISION DETAIL
  https://phabricator.kde.org/D23557

To: meven, #dolphin, elvisangelaccio
Cc: kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190915/d802a854/attachment.htm>


More information about the kfm-devel mailing list