D23655: Fixing bugs in new folders in tabs feature

Alexander Saoutkin noreply at phabricator.kde.org
Mon Sep 2 01:01:32 BST 2019


feverfew created this revision.
feverfew added a reviewer: elvisangelaccio.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
feverfew requested review of this revision.

REVISION SUMMARY
  This patch does the following:
  
  1. Fixing bug where urls in secondary view containers would not be considered
  
  for the open new folders in tabs feature.
  
  2. Defer DBus service creation until all DBus objects have been created.
  
  The DBus service currently is created too early, as we haven't created the 
  objects in the Main Window. This can cause lag as attachToExistingInstance() 
  uses blocking DBus calls.

TEST PLAN
  Manual testing. Testing for no regressions. Test via KDevelop (open with...)

REPOSITORY
  R318 Dolphin

BRANCH
  splitViewImprov (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23655

AFFECTED FILES
  src/dolphinmainwindow.cpp
  src/dolphintabwidget.cpp
  src/dolphintabwidget.h
  src/main.cpp

To: feverfew, elvisangelaccio
Cc: kfm-devel, ngraham, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190902/1ba94f39/attachment.htm>


More information about the kfm-devel mailing list