D19311: Add navigation history to forward/back buttons

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  Haven't look at the whole diff yet, since the fix for the duplicates could be quite invasive

INLINE COMMENTS

> dolphinmainwindow.cpp:95-103
> +    const int MaxNumberOfNavigationentries = 100;
> +    // Converts a QUrl to a QString suitable for showing in the back/forward popup menu
> +    QString GetPopupMenuLabel(const QUrl& url)
> +    {
> +        if (url.isLocalFile()) {
> +            return url.adjusted(QUrl::RemoveScheme).toString();
> +        }

The problem is that the menu can become huge and fill the whole screen: F7350920: Screenshot_20190914_163901.png <https://phabricator.kde.org/F7350920>

Another problem from this screenshot: if an URL is already in the history, don't add it again.

> dolphinmainwindow.cpp:694
> +{
> +    KUrlNavigator* urlNav = m_activeViewContainer->urlNavigator();
> +    int entries = 0;

please call it `urlNavigator`

> dolphinmainwindow.cpp:707
> +    int gotoIndex = action->data().value<int>();
> +    KUrlNavigator* urlNav = m_activeViewContainer->urlNavigator();
> +    for (int numBack = gotoIndex - urlNav->historyIndex(); numBack; --numBack) {

please call it `urlNavigator`

> dolphinmainwindow.cpp:723
> +{
> +    KUrlNavigator* urlNav = m_activeViewContainer->urlNavigator();
> +    int entries = 0;

please call it `urlNavigator`

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19311

To: hallas, #dolphin, ngraham, elvisangelaccio, #vdg
Cc: felixernst, nerdopolist, mart, richardl, ognarb, david.fontanals, abetts, kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190914/d1d45a15/attachment.htm>