D23538: [dolphin] Animate gifs on preview

[Méven Car]

meven added a comment.


  In D23538#529492 <https://phabricator.kde.org/D23538#529492>, @iasensio wrote:
  
  > This is an screenshot on current `master` code, without this patch. I'd like for the `animatedImage` to follow also the path on line 271.
  >  F7341053: dolphininfo_code1.png <https://phabricator.kde.org/F7341053>
  
  
  Thank you for your patience, I was wrong. I got confused by the way phabricator collapse code, my bad.
  So in the end  the `if (isAnimatedImage) {` block could go to the else branch of `if (usePhonon)`
  
  I have tested it. It works nicely.
  
  Please wait a bit before merging so that @elvisangelaccio can have a look.
  If he does not have time I will eventually accept it as is.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23538

To: iasensio, #dolphin, #vdg, ngraham, elvisangelaccio
Cc: pino, fuksitter, meven, broulik, kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190912/71df183c/attachment.htm>