D23538: [dolphin] Animate gifs on preview

Nathaniel Graham noreply at phabricator.kde.org
Wed Sep 11 18:47:40 BST 2019


ngraham added a comment.


  Ugh, those kinds of if/else blocks are always confusing. I would (in another patch) re-arrange it so everything currently in the else block comes first (`if (!usePhonon) { blabla`) to get that small bit out of the way first so the more complex logic can come next without an else block after it.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23538

To: iasensio, #dolphin, #vdg, ngraham, elvisangelaccio
Cc: pino, fuksitter, meven, broulik, kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190911/e5c30fbc/attachment.htm>


More information about the kfm-devel mailing list