D24450: [dolphin/search] Reset search options when needed

Elvis Angelaccio noreply at phabricator.kde.org
Sun Oct 13 16:42:43 BST 2019


elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> dolphinfacetswidget.h:53
>  
> +    void setEnabled(bool enable);
> +    void resetOptions();

`QWidget::setEnabled()` is not `virtual`, so we should not create another `setEnabled()` method in a child class.

You can use the `QEvent::EnabledChange` event instead: https://doc.qt.io/qt-5/qwidget.html#enabled-prop

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D24450

To: iasensio, #dolphin, elvisangelaccio, meven, ngraham
Cc: kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191013/bd86b88f/attachment.htm>


More information about the kfm-devel mailing list