D24450: [dolphin/search] Reset search options when needed

Ismael Asensio noreply at phabricator.kde.org
Tue Oct 8 15:07:02 BST 2019


iasensio added inline comments.

INLINE COMMENTS

> meven wrote in dolphinfacetswidget.h:53
> It is not used yet it seems, I guess you are planning to.

It is used in fact in line 111 of `dolphinsearchbox.cpp`: `m_facetsWidget->setEnabled(hasFacetsSupport);`, but you are right: this helps a lot the merging of other revisions (and IMHO conceptually makes sense).

REPOSITORY
  R318 Dolphin

BRANCH
  search_parse_reset

REVISION DETAIL
  https://phabricator.kde.org/D24450

To: iasensio, #dolphin, elvisangelaccio, meven, ngraham
Cc: kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191008/8472c5e0/attachment.htm>


More information about the kfm-devel mailing list