D24353: Add actions for switching to a specific tab

Méven Car noreply at phabricator.kde.org
Thu Oct 3 10:10:41 BST 2019


meven added inline comments.

INLINE COMMENTS

> dolphinmainwindow.cpp:1512
> +
> +        if (i < 10) {
> +            const int numberForShortcut = (i == 9) ? 0 : i + 1;

Simplier written with one check instead of two (i is < MaxActivateTabShortcuts) :

  int numberForShortcut;
  if (i == 9) {
       // tenth
       numberForShortcut = 0;
  } else {
      numberForShortcut = i + 1;
  }

REPOSITORY
  R318 Dolphin

BRANCH
  feature-tab-shortcuts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24353

To: alexmi, #vdg, #dolphin, ngraham
Cc: meven, ngraham, elvisangelaccio, kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191003/2cf11fcf/attachment.htm>


More information about the kfm-devel mailing list