D25258: test(search): Add test case for baloo parsing model

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> dolphinquerytest.cpp:42-48
> +void DolphinSearchBoxTest::init()
> +{
> +}
> +
> +void DolphinSearchBoxTest::cleanup()
> +{
> +}

Why empty? We should just remove them if we don't need any custom init/cleanup logic.

> dolphinquerytest.cpp:99
> +    QJsonDocument doc(jsonObject);
> +    QString queryString = QString::fromUtf8(doc.toJson(QJsonDocument::Compact));
> +

`const`

> dolphinquerytest.cpp:123
> +    const QUrl testUrl = composeQueryUrl(searchString);
> +    DolphinQuery queryModel = DolphinQuery::fromBalooSearchUrl(testUrl);
> +

just `query` as variable name.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D25258

To: iasensio, elvisangelaccio, bruns, #dolphin
Cc: kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191113/ccf4c519/attachment.htm>