D25258: test(search): Add test case for baloo parsing model
Ismael Asensio
noreply at phabricator.kde.org
Wed Nov 13 00:26:43 GMT 2019
iasensio updated this revision to Diff 69661.
iasensio marked 8 inline comments as done.
iasensio added a comment.
- Move to a different test unit
- Address comments
Most of the boilerplate went away after separating the test and not needing `DolphinSearchBox` anymore
I also removed the `#ifdef HAVE_BALOO` guards since the test is within `if (KF5Baloo_FOUND)` in cmake.
REPOSITORY
R318 Dolphin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25258?vs=69584&id=69661
BRANCH
test_search_model
REVISION DETAIL
https://phabricator.kde.org/D25258
AFFECTED FILES
src/CMakeLists.txt
src/search/dolphinfacetswidget.cpp
src/search/dolphinquery.cpp
src/search/dolphinquery.h
src/search/dolphinsearchbox.cpp
src/search/dolphinsearchbox.h
src/tests/CMakeLists.txt
src/tests/dolphinquerytest.cpp
To: iasensio, elvisangelaccio, bruns, #dolphin
Cc: kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191113/242f6c18/attachment.htm>
More information about the kfm-devel
mailing list