D25258: test(search): Add test case for baloo parsing model

Stefan BrĂ¼ns noreply at phabricator.kde.org
Mon Nov 11 22:24:26 GMT 2019


bruns added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in dolphinsearchboxtest.cpp:57
> Please try to use `QVERIFY(QTest::qWaitForWindowExposed(m_searchBox));` in the actual test instead.

And unrelated, separate review please. Also likely unnecessary, as `testTextClearing` already has a `show()`.

> dolphinsearchboxtest.cpp:98
> +    const QString rating = QStringLiteral("rating>=2 ");
> +    const QString modified = QString("modified>=%1 ").arg(QDate::currentDate().toString(Qt::DateFormat::ISODate));
> +

use a fixed datetime here.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D25258

To: iasensio, elvisangelaccio, bruns, #dolphin
Cc: kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191111/b1b009d9/attachment.htm>


More information about the kfm-devel mailing list