D25257: refactor(search): De-couple baloo URL parsing logic from UI
Elvis Angelaccio
noreply at phabricator.kde.org
Tue Nov 12 22:54:04 GMT 2019
elvisangelaccio added inline comments.
INLINE COMMENTS
> dolphinsearchbox.h:158
> */
> - void fromBalooSearchUrl(const QUrl& url);
> + void updateFromModel(const DolphinQuery *queryModel);
>
Since we renamed the class, this should be renamed too. `updateFromQuery(const DolphinQuery *query)` ?
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D25257
To: iasensio, #dolphin, elvisangelaccio, bruns
Cc: bruns, kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191112/d91a2726/attachment.htm>
More information about the kfm-devel
mailing list