D25257: refactor(search): De-couple baloo URL parsing logic from UI

Stefan BrĂ¼ns noreply at phabricator.kde.org
Tue Nov 12 22:51:22 GMT 2019


bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> dolphinsearchbox.cpp:503
>  
> -void DolphinSearchBox::fromBalooSearchUrl(const QUrl& url)
> +void DolphinSearchBox::updateFromModel(const DolphinQuery *queryModel)
>  {

`const&` instead of `*`.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D25257

To: iasensio, #dolphin, elvisangelaccio, bruns
Cc: bruns, kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191112/2d547339/attachment.htm>


More information about the kfm-devel mailing list