D19989: Unmounting busy device doesn't tell who is blocking

[Elvis Angelaccio]

elvisangelaccio added a comment.


  I'd also try to avoid copying the code here, is possible.
  
  In D19989#436601 <https://phabricator.kde.org/D19989#436601>, @hallas wrote:
  
  > In D19989#436598 <https://phabricator.kde.org/D19989#436598>, @broulik wrote:
  >
  > > Solid's signal `void setupDone(Solid::ErrorType error, QVariant errorData, const QString &udi);` has an `errorData` where you could probably send this to all interested parties without having to recreate this code all over the place
  >
  >
  > So what you are saying is to move the `queryBlockingApps` functionality to Solid? What about the dependency to KSysGuard, is that ok to add to Solid?
  
  
  As long as it'd be an optional dependency, it //should// be fine, as I don't see it forbidden here: https://community.kde.org/Frameworks/Policies
  
  But maybe send a mail to kde-frameworks-devel to double check ;)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19989

To: hallas, #dolphin, elvisangelaccio, ngraham, broulik
Cc: kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190323/8d24da29/attachment.htm>