D19485: Fixes leak of DolphinFileMetaDataWidget in ToolTipManager
Elvis Angelaccio
noreply at phabricator.kde.org
Sat Mar 9 21:38:24 GMT 2019
elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> tooltipmanager.cpp:88
> this, &ToolTipManager::slotMetaDataRequestFinished);
> - connect(m_fileMetaDataWidget, &DolphinFileMetaDataWidget::urlActivated,
> + connect(m_fileMetaDataWidget.get(), &DolphinFileMetaDataWidget::urlActivated,
> this, &ToolTipManager::urlActivated);
`QScopedPointer::get()` is Qt 5.11+ only, please use `QScopedPointer::data()` instead.
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D19485
To: hallas, #dolphin, elvisangelaccio
Cc: kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190309/63f6ce2c/attachment.htm>
More information about the kfm-devel
mailing list