D19485: Fixes leak of DolphinFileMetaDataWidget in ToolTipManager

[David Hallas]

hallas added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in tooltipmanager.cpp:85-86
> > If there is only a single reset then there will be a short period of time where two DolphinFileMetaDataWidget instances are allocated because first the new DolphinFileMetaDataWidget is allocated, then it it passed to the reset function, which deletes the instance it owns and keeps the new one.
> 
> Hmm, this feels like a theoretical problem only. IMHO readability and consistency of code should be preferred (we don't reset a `QScopedPointer` like this anywhere else in dolphin).

I have removed the extra `reset` to keep things consistent :)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19485

To: hallas, #dolphin, elvisangelaccio
Cc: kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190309/8f17e8d5/attachment.htm>