D19485: Fixes leak of DolphinFileMetaDataWidget in ToolTipManager

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> tooltipmanager.cpp:85-86
>      // meta data retrieval, when passing rapidly over a lot of items.
> -    delete m_fileMetaDataWidget;
> -    m_fileMetaDataWidget = new DolphinFileMetaDataWidget();
> -    connect(m_fileMetaDataWidget, &DolphinFileMetaDataWidget::metaDataRequestFinished,
> +    m_fileMetaDataWidget.reset();
> +    m_fileMetaDataWidget.reset(new DolphinFileMetaDataWidget());
> +    connect(m_fileMetaDataWidget.get(), &DolphinFileMetaDataWidget::metaDataRequestFinished,

Why `reset()` it twice? The second `reset()` call should be enough

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19485

To: hallas, #dolphin, elvisangelaccio
Cc: kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190309/2759be09/attachment.htm>