D19485: Fixes leak of DolphinFileMetaDataWidget in ToolTipManager

David Hallas noreply at phabricator.kde.org
Sun Mar 3 06:41:35 GMT 2019


hallas created this revision.
hallas added reviewers: Dolphin, elvisangelaccio.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
hallas requested review of this revision.

REVISION SUMMARY
  Fixes leak of DolphinFileMetaDataWidget in ToolTipManager. The
  destructor of ToolTipManager failed to delete the m_fileMetaDataWidget
  member. This is seen at shutdown but also when you close a tab that has
  displayed a tooltip.

TEST PLAN
  Compile Dolphin with address sanitizer
  Open Dolphin
  Show a tooltip
  Close Dolphin

REPOSITORY
  R318 Dolphin

BRANCH
  fixes_leak_of_dolphin_file_meta_data_widget (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19485

AFFECTED FILES
  src/views/tooltips/tooltipmanager.cpp
  src/views/tooltips/tooltipmanager.h

To: hallas, #dolphin, elvisangelaccio
Cc: kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190303/c845f7da/attachment.htm>


More information about the kfm-devel mailing list