D22116: [KStandardItemListWidget] Request the pixmap size we want and let the icon loader scale it

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Jun 27 11:28:47 BST 2019


broulik added inline comments.

INLINE COMMENTS

> kstandarditemlistwidget.cpp:1475
> +        pixmap = icon.pixmap(size / qApp->devicePixelRatio(), size / qApp->devicePixelRatio(), mode);
> +        if (pixmap.width() != size || pixmap.height() != size) {
>              KPixmapModifier::scale(pixmap, QSize(size, size));

I also never hit this codepath now... perhaps that's a behavioral change from using `KIconLoader` which might pad the icons to `QIcon` which will just bluntly scale?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22116

To: broulik, #dolphin, elvisangelaccio
Cc: kfm-devel, fprice, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190627/aa3a91d8/attachment.htm>


More information about the kfm-devel mailing list