D21789: Fix tests relating to the removal of the Root Place in D15739

Elvis Angelaccio noreply at phabricator.kde.org
Sun Jun 16 21:32:18 BST 2019


elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  I'd avoid to bump the KF5 version only because of a test.
  
  What we can do instead is to add the following check in `src/tests/CMakeLists.txt` :
  
    if (KIO_VERSION VERSION_GREATER_EQUAL "5.60.0")
        ecm_add_test(placesitemmodeltest.cpp ...)
    endif()

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D21789

To: meven, elvisangelaccio, ngraham
Cc: kfm-devel, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190616/6860a8f1/attachment.htm>


More information about the kfm-devel mailing list