D21789: Fix tests relating to the removal of the Root Place in D15739

Nathaniel Graham noreply at phabricator.kde.org
Fri Jun 14 14:27:27 BST 2019


ngraham added a comment.


  In D21789#479548 <https://phabricator.kde.org/D21789#479548>, @meven wrote:
  
  > I may need to add some sort of "#if KIO_VERSION < QT_VERSION_CHECK(5,60,0)" all over the place.
  >  I have tried it but I haven't found similar patterns to base upon.
  >  If I don't, it will make dolphin tests depends on kio master/5.60, unless this is tolerable.
  >  I don't know the expectancies on tests.
  >  Your call @elvisangelaccio.
  
  
  Probably makes sense to bump the Frameworks dependency version instead (safe since we're still in master development), but yeah, it's @elvisangelaccio's call.

REPOSITORY
  R318 Dolphin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21789

To: meven, elvisangelaccio, ngraham
Cc: kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190614/93afc1f5/attachment.htm>


More information about the kfm-devel mailing list