D21600: [DolphinContextMenu] Restore check for whether place already exists

Elvis Angelaccio noreply at phabricator.kde.org
Wed Jun 5 22:35:24 BST 2019


elvisangelaccio added inline comments.

INLINE COMMENTS

> dolphincontextmenu.cpp:467
> +    for (int i = 0; i < model->rowCount(); ++i) {
> +        if (model->url(model->index(i, 0)).matches(url, QUrl::StripTrailingSlash)) {
> +            return true;

I know this is what the old code did, but could you try to use

  model->match(..., KFilePlacesModel::UrlRole, ...);

like you did in commit 652f57d28152491c4 <https://phabricator.kde.org/R318:652f57d28152491c42ad740d2bacd12a12d3d3d7> ?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D21600

To: broulik, #dolphin, elvisangelaccio
Cc: ngraham, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190605/3fc02b67/attachment.htm>


More information about the kfm-devel mailing list