D21600: [DolphinContextMenu] Restore check for whether place already exists

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> dolphincontextmenu.cpp:464
>  {
> -    Q_UNUSED(url)
> -    // Creating up a PlacesItemModel to find out if 'url' is one of the Places
> -    // can be expensive because the model asks Solid for the devices which are
> -    // available, which can take some time.
> -    // TODO: Consider restoring this check if the handling of Places and devices
> -    // will be decoupled in the future.
> +    KFilePlacesModel *model = DolphinPlacesModelSingleton::instance().placesModel();
> +

Const?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D21600

To: broulik, #dolphin, elvisangelaccio
Cc: ngraham, kfm-devel, LeGast00n, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190605/c9b6e775/attachment.htm>