D16648: Open externally called files/directories in new tabs

[Thomas Posch]

thomasp added a comment.


  Reopening because I believe this is broken in combination with activities.
  
  Problem 1:
  You can not start a new Dolphin window on any activity as long as you have Dolphin open on any other activity.
  
  Steps to reproduce:
  Launch Dolphin on activity 1.
  Launch Dolphin on activity 2.
  Expected behaviour: Dolphin is running on activity 2.
  Actual behaviour: your current activity is switched from 2 to 1.
  Activities are meant to separate different tasks. Opening a tab on a different activity defeats the purpose.
  Workaround: Open a new tab on the activity you were switched to. Detach the tab and move the new window to the activity you wanted Dolphin to open on.
  Workaround 2: don't use the GUI to launch Dolphin but type dolphin --new-window into KRunner or Konsole.
  
  Problem 2:
  You are moved to a different activity if there happens to be a window with the path to open.
  
  Steps to reproduce:
  Launch Dolphin on activity 1.
  Launch Dolphin on activity 2 (same path as on activity 1).
  Make sure Dolphin on activity 2 has a DBus name sorting after activity 1.
  Launch Dolphin on activity 2.
  Expected behaviour: Switch to Dolphin on activity 2.
  Actual behaviour: You are switched to Dolphin on activity 1.
  
  Problem 3:
  You are moved to a different activity if there happens to be a Dolphin window with the path to open (2).
  
  Steps to reproduce:
  Launch Dolphin on activity 1 with path /foo.
  Launch Dolphin on activity 2 with path /bar.
  Make sure Dolphin on activity 2 has a DBus name sorting before activity 1.
  Launch Dolphin on activity 2 with path /foo.
  Expected behaviour: The path /foo is opened in a tab on activity 2.
  Actual behaviour: You are switched to activity 1.
  
  Problem 4:
  You are moved to a different activity if there happens to be a Dolphin window on a different activity where the DBus name sorts before the Dolphin window of the current activity.
  
  Steps to reproduce:
  Launch Dolphin on activity 1 with path /foo.
  Launch Dolphin on activity 2 with path /bar.
  Make sure Dolphin on activity 2 has a DBus name sorting after activity 1.
  Launch Dolphin on activity 2 with path /baz.
  Expected behaviour: The path /baz is opened in a tab on activity 2.
  Actual behaviour: You are switched to activity 1 where /baz is opened in a new tab.
  
  All of the above boils down to pseudo random behaviour if you have multiple activities and multiple Dolphin windows.
  
  If you are used to the behaviour of Firefox which opens new URLs in the most recently used window the implemented behaviour is odd even on single activity/desktop setups since all new tab request (with unique URL) are opened in the window with the lowest DBus unique connection name.
  
  Thank you for your consideration.
  And thank you for putting all the work into KDE.
  
  Note: DBus probably returns the services ordered by their connection names and not sorted by well-known name, so the first started dolphin window might always be considered the 'main' window even if the pid wraps around.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D16648

To: feverfew, #dolphin, elvisangelaccio
Cc: thomasp, zzag, dfaure, fvogt, fikrim, magar, fbg13, davidedmundson, kwin, ngraham, elvisangelaccio, anthonyfieroni, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190602/c5897373/attachment.htm>