D22183: Add click to play/play feature on previews for audio/video

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> informationpanelcontent.cpp:341-343
> +        auto pixicon = icon.pixmap(44, 44);
> +        // border of the arrow
> +        auto pixborder = icon.pixmap(48, 48);

Is it possible to not hardcode these numbers?

> informationpanelcontent.cpp:348-350
> +        {
> +            if(qAlpha(img.pixel(i,j)) != 0)
> +            {

Coding style: opening brace should go to the end of previous line.

> phononwidget.cpp:98
>  
> +bool PhononWidget::eventFilter(QObject *object, QEvent *event) {
> +    Q_UNUSED(object);

Coding style: opening brace should go the next line for functions.

> phononwidget.cpp:100
> +    Q_UNUSED(object);
> +    if (event->type() == QEvent::MouseButtonPress){
> +        const QMouseEvent *mouseEvent = static_cast<QMouseEvent*>(event);

Missing space before brace

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22183

To: meven, elvisangelaccio, #dolphin, ngraham
Cc: shubham, anthonyfieroni, ngraham, kfm-devel, aprcela, fprice, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190717/de9d03ef/attachment.htm>