D22183: Add click to play/play feature on previews for audio/video

[Méven Car]

meven added a comment.


  In D22183#496838 <https://phabricator.kde.org/D22183#496838>, @ngraham wrote:
  
  > Hmm, the triangle looks kinda janky with a 2x scale factor: F7038622: Screenshot_20190717_092246.png <https://phabricator.kde.org/F7038622>
  >
  > It's worse with a factional scale factor (1.5 here): F7038620: Screenshot_20190717_092153.png <https://phabricator.kde.org/F7038620>
  
  
  The janky-ness is what I meant with not satisfying.
  In the 1.5 scale factor, the positioning of the arrow is off as well, smells like a rounding issue, I will look into.
  
  > The new feature deadline is tomorrow; I say we polish this up and land it for 19.12 instead of rushing it into 19.08.
  
  I agree no rush.

REPOSITORY
  R318 Dolphin

BRANCH
  arcpatch-D22183

REVISION DETAIL
  https://phabricator.kde.org/D22183

To: meven, elvisangelaccio, #dolphin, ngraham
Cc: shubham, anthonyfieroni, ngraham, kfm-devel, aprcela, fprice, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190717/e50039a9/attachment.htm>