D17640: [versioncontrolobserver] Do not use static plugin objects

Elvis Angelaccio noreply at phabricator.kde.org
Tue Jan 29 10:46:36 GMT 2019


elvisangelaccio added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in dolphinview.cpp:191
> Ensures current tab is in sync with gitWrapper in dolphin plugins witch is singleton i.e. when you click tab it call git status on current directory. This line is pretty simple fix, without adding other slot, if we want new syntax we should add new public slot that call internally delayedDirectoryVerification

Ok, so it's another bugfix but unrelated from this patch. Please move it to another commit then.

And yes, we should try to use the new syntax if possible.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D17640

To: anthonyfieroni, elvisangelaccio, dfaure, #dolphin
Cc: alexeymin, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190129/d763c34c/attachment.htm>


More information about the kfm-devel mailing list