D17640: [versioncontrolobserver] Do not use static plugin objects
Anthony Fieroni
noreply at phabricator.kde.org
Tue Jan 29 06:35:58 GMT 2019
anthonyfieroni added inline comments.
INLINE COMMENTS
> elvisangelaccio wrote in dolphinview.cpp:191
> Not really. What's this connection needed for?
>
> If we really need it, we should find a better way.
Ensures current tab is in sync with gitWrapper in dolphin plugins witch is singleton i.e. when you click tab it call git status on current directory. This line is pretty simple fix, without adding other slot, if we want new syntax we should add new public slot that call internally delayedDirectoryVerification
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D17640
To: anthonyfieroni, elvisangelaccio, dfaure, #dolphin
Cc: alexeymin, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190129/b65aadd9/attachment.htm>
More information about the kfm-devel
mailing list