D18289: [gitpushgialog] Check index validity

[Anthony Fieroni]

anthonyfieroni added a comment.


  In D18289#397527 <https://phabricator.kde.org/D18289#397527>, @alexeymin wrote:
  
  > `branches` is a `QStringList`, so, we could also check that `currentBranchIndex < branches.size()` in  condition, if it is all about bounds checking.
  
  
  In this case GitWrapper::branches sets valid index or -1, so it's not need bound check.

REPOSITORY
  R449 Plugins for Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D18289

To: anthonyfieroni, elvisangelaccio, #dolphin, alexeymin
Cc: alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190121/a0f2feca/attachment.htm>