D18289: [gitpushgialog] Check index validity

[Alexey Min]

alexeymin accepted this revision.
alexeymin added a comment.
This revision is now accepted and ready to land.


  `branches` is a `QStringList`, so, we could also check that `currentBranchIndex < branches.size()` in  condition, if it is all about bounds checking.
  Anyway, the diff compiles and overall looks harmless. I'd say +1, I did not try to reproduce the crash though

REPOSITORY
  R449 Plugins for Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D18289

To: anthonyfieroni, elvisangelaccio, #dolphin, alexeymin
Cc: alexeymin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190121/629eb7b2/attachment.htm>