D19201: New tab placed after current tab when middle-clicking

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> dolphinmainwindow.h:50
>  class TerminalPanel;
> +enum class DolphinTabPlacement;
>  

This is a bit weird, never seen forward declarations used for an enum. Why not just `#include "dolphintabwidget.h" `?

> hallas wrote in dolphintabwidget.h:33
> @elvisangelaccio  - do you have any comments for this?

No it's fine here. But why make it an `enum class`? Is it because you wanted to forward declare it? If yes, see my comment above.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19201

To: hallas, #dolphin, ngraham, elvisangelaccio
Cc: kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190224/f866a1ae/attachment.htm>