D19241: Show the FileMetaDataConfigurationDialog dialog only after its widget has emmitted metadataLoaded signal

Elvis Angelaccio noreply at phabricator.kde.org
Sat Feb 23 19:02:37 GMT 2019


elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  > Is the design of letting dialog choosing when to show up ok ?
  
  Please don't, a `QDialog` is supposed to be shown by using `show()` or `open()`, it shouldn't open on its own.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19241

To: meven, #dolphin, elvisangelaccio
Cc: elvisangelaccio, ngraham, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190223/3cbb73fb/attachment.htm>


More information about the kfm-devel mailing list