D23538: [dolphin] Animate gifs on preview

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> iasensio wrote in pixmapviewer.cpp:115
> It's a common pattern in plain C. If `m_animatedImage` is evaluated `false`, it doesn't check the rest of the condition. It doesn't crash now for me but I'm guessing that it's not a good pattern in C++. Any ideas on how to do it while keeping it simple?
> Thanks for the patience 😃

You're probably right and I'm being dense

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23538

To: iasensio, #dolphin, #vdg, ngraham, elvisangelaccio
Cc: meven, broulik, kfm-devel, vmarinescu, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190829/8d0c08b4/attachment.htm>