D23538: [dolphin] Animate gifs on preview

[Ismael Asensio]

iasensio added a comment.


  About checking for `m_animatedImage`

INLINE COMMENTS

> ngraham wrote in pixmapviewer.cpp:115
> Need to move the check for `m_animatedImage` separately since if it doesn't already exist, the call to `m_animatedImage->state()` will crash

It's a common pattern in plain C. If `m_animatedImage` is evaluated `false`, it doesn't check the rest of the condition. It doesn't crash now for me but I'm guessing that it's not a good pattern in C++. Any ideas on how to do it while keeping it simple?
Thanks for the patience 😃

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23538

To: iasensio, #dolphin, #vdg, ngraham, elvisangelaccio
Cc: meven, broulik, kfm-devel, vmarinescu, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190829/468b7ab9/attachment.htm>