D23538: [dolphin] Animate gifs on preview

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> pixmapviewer.cpp:104
> +    if (!m_animatedImage) {
> +        return QString::null;
> +    }

return `QString()` instead of `QString::null`

> pixmapviewer.cpp:115
>  
> -    if (m_transition != NoTransition) {
> +    if (m_transition != NoTransition || (m_animatedImage && m_animatedImage->state() != QMovie::Running)) {
>          const float value = m_animation.currentValue();

Need to move the check for `m_animatedImage` separately since if it doesn't already exist, the call to `m_animatedImage->state()` will crash

> pixmapviewer.cpp:144
>          m_animation.start();
> +    } else if (m_animatedImage && m_animatedImage->isValid() && m_animatedImage->frameCount() > 1) {
> +        m_animatedImage->setScaledSize(m_pixmap.size());

ditto

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23538

To: iasensio, #dolphin, #vdg, ngraham, elvisangelaccio
Cc: meven, broulik, kfm-devel, vmarinescu, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190829/7834821a/attachment.htm>