D23538: [dolphin] Animate gifs on preview

[Ismael Asensio]

iasensio added a comment.


  I also added `stopAnimatedImage()` because stopping it by passing an empty filename was kind of hacky

INLINE COMMENTS

> ngraham wrote in pixmapviewer.cpp:45
> No need to create a new QMovieObject unless there's actually an animated image loaded; I'd create it on demand and then handle the case where `m_movie` is null.

Should it also be destroyed on animation stopping? Or only if a different non-animated item gets loaded? Or that would be an extra penalty in creation/destruction.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23538

To: iasensio, #dolphin, #vdg, ngraham, elvisangelaccio
Cc: meven, broulik, kfm-devel, vmarinescu, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190829/1641f4e4/attachment.htm>