D23475: [baloo-widgets] Apply condensed date to file metadata properties

Stefan BrĂ¼ns noreply at phabricator.kde.org
Thu Aug 29 12:53:50 BST 2019


bruns added a comment.


  I think it would be preferable to do this in KFM::PropertyInfo

INLINE COMMENTS

> widgetfactory.cpp:160
>  
> +QString WidgetFactory::formatDateTime(const QVariant& value)
> +{

no need for this to be a member function.

> widgetfactory.cpp:175
> +
> +    return QString::null;
> +}

no QString::null please!

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D23475

To: iasensio, #dolphin, elvisangelaccio, bruns
Cc: meven, ngraham, bruns, #baloo, vmarinescu, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, domson, ashaposhnikov, astippich, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190829/30733984/attachment.htm>


More information about the kfm-devel mailing list