D23475: [baloo-widgets] Apply condensed date to file metadata properties
Méven Car
noreply at phabricator.kde.org
Thu Aug 29 10:05:35 BST 2019
meven added inline comments.
INLINE COMMENTS
> widgetfactory.cpp:148
> + if (valueString == QString::null) {
> + valueString = toString(value);
> + }
It seems to me extending toString function to support DateTime and Date QVariant type and use formatDateTime there, would allow to make the code leaner, instead of extending here if/else cascade here.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D23475
To: iasensio, #dolphin, elvisangelaccio, bruns
Cc: meven, ngraham, bruns, #baloo, vmarinescu, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, domson, ashaposhnikov, astippich, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190829/11ae0882/attachment.htm>
More information about the kfm-devel
mailing list