D23458: Don't store view properties on network shares

Méven Car noreply at phabricator.kde.org
Mon Aug 26 09:42:32 BST 2019


meven added a comment.


  I'd really like this code to be in a lib rather that repeating all over the place.
  Something like `bool Solid::IsOnNetworkShare(path)`

INLINE COMMENTS

> viewproperties.cpp:81
> +            for (Solid::Device device : devices) {
> +                Solid::StorageAccess *storageAccess = device.as<Solid::StorageAccess>();
> +                if (m_filePath.startsWith(storageAccess->filePath())) {

You can add a const here.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23458

To: broulik, #dolphin, meven, dfaure
Cc: kfm-devel, aprcela, vmarinescu, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190826/6aba077d/attachment.htm>


More information about the kfm-devel mailing list