D23458: Don't store view properties on network shares

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Dolphin, meven, dfaure.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Inspired by D23420 <https://phabricator.kde.org/D23420>
  Entering a folder will have Dolphin determine whether it can store the view properties in a `.directory` file within the folder or in a generic config location.
  It does so by checking for permissions on the file and parent dir causing various stat calls that potentially block on a slow mount. Also, the config reading thereafter can be very slow.
  Moreover, network shares are typically shared between users, so one user's view properties shouldn't affect or be overwritten by this Dolphin instance.

TEST PLAN
  Mounted a slow mount, entered the folder, did no longer block in `ViewProperties` at all.
  Settings were written to `~/.local/share/dolphin/view_properties/local/home/foo/slowmount/.directory` instead of `~/myslowmount/.directory`
  Since Solid has already been set up by `KFilePlacesModel`, the overhead of this is negligible.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23458

AFFECTED FILES
  src/views/viewproperties.cpp

To: broulik, #dolphin, meven, dfaure
Cc: kfm-devel, aprcela, vmarinescu, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190826/80a38b36/attachment.htm>