D11382: Add an option to show tabs from last time when Dolphin starts

Nathaniel Graham noreply at phabricator.kde.org
Mon Aug 19 03:07:44 BST 2019


ngraham added a comment.


  Thanks for the comments, @feverfew. Your assistance is definitely appreciated given that you wrote a lot of the code I'm mangling here.

INLINE COMMENTS

> feverfew wrote in dolphinmainwindow.cpp:196
> I'm surprised this works at all. AFAICTL it'll never be empty as the instance will find itself and hence won't be empty, unless our DBus interface isn't initialised yet (tbf I don't know when it would be). Either way I don't see why this instance is preferred so I think the code would be clearer if it was simply QString() instead.

It doesn't find itself because `Dolphin::dolphinInstanceData()` filters out the currently running instance by excludinv entries that match its PID.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11382

To: ngraham, #dolphin, #vdg, rominf
Cc: intika, feverfew, kfm-devel, ngraham, broulik, #dolphin, aprcela, vmarinescu, fprice, MrPepe, fbampaloukas, alexde, Codezela, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190819/d5dba657/attachment.htm>


More information about the kfm-devel mailing list