D23232: [dolphin] Add an action to toggle the searchbar

[Felix Ernst]

felixernst added a comment.


  I think it is fine having two actions that both open the Search/Findbar. The new 'toggle-search' would replace 'open-search' in the Toolbar and 'open-search' would still be associated with Ctrl+F.
  This is similar to having two actions for typing a new location:
  F7258719: image.png <https://phabricator.kde.org/F7258719>
  Making the names of the two actions more distinct might be enough to keep the users from getting super confused.
  
  I think the expected behaviour when pressing Ctrl+F should probably stay as it is because that is also somewhat consistent with the behaviour of browsers when pressing Ctrl+F. (I personally don't have a preference here.)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23232

To: iasensio, #dolphin, ngraham, #vdg
Cc: felixernst, elvisangelaccio, kfm-devel, aprcela, vmarinescu, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190818/fa65ac7b/attachment.htm>