D23232: [dolphin] Add an action to toggle the searchbar

[Nathaniel Graham]

ngraham added a reviewer: VDG.
ngraham added a comment.


  Giving choice to the user isn't really the best solution here IMO. The fact that these toolbars are customizable at all is not widely known, and allowing people to choose between multiple actions that both do the same thing except for one slightly different close/focus behavior is likely to be super confusing to everyone who's not a Dolphin developer. :) Adding #VDG <https://phabricator.kde.org/tag/vdg/> for more opinions and comments.
  
  If it's really impossible to gain the desired behavior, my personal preference would be to make it a pure toggle action and live with the fact that hitting the shortcut will always toggle it. While this may be slightly irritating for people who want to keep it open all the time, part of the reason why they might want to do that is because it's not as easy to close as it could be. So maybe they'll be able to easily adjust to the new behavior and even gain some space by not having to have it open all the time.
  
  We probably need @elvisangelaccio's input on this (he's the Dolphin maintainer). IIRC he's on vacation right now and will be back in a week or so.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23232

To: iasensio, #dolphin, ngraham, #vdg
Cc: elvisangelaccio, kfm-devel, aprcela, vmarinescu, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190818/c8964b7c/attachment.htm>